fix: remove malformed type attribute from html tag in PDF template#2806
Draft
yyq1043-cloud wants to merge 1 commit into
Draft
fix: remove malformed type attribute from html tag in PDF template#2806yyq1043-cloud wants to merge 1 commit into
yyq1043-cloud wants to merge 1 commit into
Conversation
Contributor
Author
|
Hi! I'd like to request review for this PR: Fix broken HTML tag in simple_report_pdf.tpl |
Owner
|
Thanks! The one-line |
soxoj
changed the title
Contributor
Author
|
Hi! I'd like to request review for this PR: [WIP] Fix broken HTML tag in simple_report_pdf.tpl |
yyq1043-cloud
force-pushed
the
fix/pdf-template-broken-html-tag
branch
from
62d4e9f to
f8e90c5
Compare
yyq1043-cloud
changed the title
The opening <html> tag contains a malformed type="text/css" attribute which makes the HTML invalid (leading > missing). In HTML5 the <html> tag does not require any attributes. Fixes the malformed HTML that appears in generated PDF reports.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix the malformed
<html>tag on line 1 ofsimple_report_pdf.tpl.Before:
<html>type="text/css"(broken — missing>before stray attribute)After:
<html>(valid HTML5)The
type="text/css"attribute is valid for<style>elements, not<html>. Removing it produces valid HTML in generated PDF reports.Changes
maigret/resources/simple_report_pdf.tpl: Remove brokentype="text/css"attribute from opening<html>tagThis is a standalone fix addressing only the HTML validation issue. No other files changed.